Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tx status forward port #3816

Merged
merged 8 commits into from
Aug 28, 2024
Merged

chore: tx status forward port #3816

merged 8 commits into from
Aug 28, 2024

Conversation

ninabarbakadze
Copy link
Member

@ninabarbakadze ninabarbakadze commented Aug 23, 2024 •
edited
Loading

Overview

Forward-porting some work that was only addressed on v2.x branch

@ninabarbakadze ninabarbakadze self-assigned this Aug 23, 2024
@ninabarbakadze ninabarbakadze marked this pull request as ready for review August 28, 2024 15:27
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The changes involve modifications to error handling and transaction submission logic across several test files and a transaction client implementation. Key updates include redefining error types for better specificity, restructuring test case setups for improved clarity, and enhancing assertions to focus on error codes rather than response objects. These adjustments aim to streamline error reporting and improve the overall robustness of the transaction-related tests.

Changes

Files Change Summary
app/test/big_blob_test.go Adjusted error handling in TestErrBlobsTooLarge to assert that the response is nil upon error and to compare the error code against expected values.
app/test/std_sdk_test.go Repositioned serviceClient initialization for efficiency, refined error handling to ensure responses are nil for expected errors, and improved assertions for successful transactions.
pkg/user/tx_client.go Introduced new error types BroadcastTxError and ExecutionError, modified transaction submission methods to return these new errors directly, enhancing error reporting.
pkg/user/tx_client_test.go Simplified error handling in TestConfirmTx by directly checking error codes from ExecutionError instead of using response objects.
x/blobstream/integration_test.go Reorganized serviceClient initialization to enhance test isolation, expanded logic for handling transaction submissions, and improved assertions for both successful and failed transactions.
x/signal/legacy_test.go Renamed signer to txClient, modified transaction submission method to directly call SubmitTx, and updated error handling to compare error codes from new error types, improving clarity in assertions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ninabarbakadze ninabarbakadze enabled auto-merge (squash) August 28, 2024 15:32
@celestia-bot celestia-bot requested a review from a team August 28, 2024 15:32
@ninabarbakadze ninabarbakadze merged commit b9ff23d into main Aug 28, 2024
32 checks passed
@ninabarbakadze ninabarbakadze deleted the nina/tx-client-forward-port branch August 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@cmwaters cmwaters cmwaters approved these changes

@rach-id rach-id Awaiting requested review from rach-id rach-id is a code owner

@rootulp rootulp Awaiting requested review from rootulp

Assignees

@ninabarbakadze ninabarbakadze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninabarbakadze @cmwaters @evan-forbes